-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tweak modal iframe size #2006
Conversation
I'm not a developer, but I approve this PR! Edit: I can't approve this PR 🤣 |
Thanks @chickenn00dle and @thomasguillot! |
Hey @laurelfulford, good job getting this PR merged! 🎉 Now, the Please check if this PR needs to be included in the "Upcoming Changes" and "Release Notes" doc. If it doesn't, simply remove the label. If it does, please add an entry to our shared document, with screenshots and testing instructions if applicable, then remove the label. Thank you! ❤️ |
🎉 This PR is included in version 4.5.3-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.5.4-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 4.5.5-alpha.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
This PR is a small tweak to the default iframe size on load (thanks @thomasguillot!).
See p1734437900696829-slack-newspack-reader-activation.
How to test the changes in this Pull Request:
npm run build
--newspack-ui-spacer-9
, not--newspack-ui-spacer-8
(the48px
fallback is correct, though). Note: the applied height will be overridden by inline JS.Other information: