HA: Dumb down handling of exclude_ids (#340)

* Dumb down handling of exclude_ids Fixes IE11 incompatibility with `URL` api. UI will now always add all IDs of displayed posts, the endpoint will always remove it from its next url. * Encode URL before using it. Props @WunderBart.
Automattic · Jan 22, 2020 · 2faed01 · 2faed01
1 parent b3cc58e
commit 2faed01
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/blocks/homepage-articles/class-wp-rest-newspack-articles-controller.php b/src/blocks/homepage-articles/class-wp-rest-newspack-articles-controller.php
@@ -107,8 +107,9 @@ function( $attribute ) {
 						$attributes
 					),
 					[
-						'page' => $next_page,
-						'amp'  => $request->get_param( 'amp' ),
+						'exclude_ids' => false,
+						'page'        => $next_page,
+						'amp'         => $request->get_param( 'amp' ),
 					]
 				),
 				rest_url( '/newspack-blocks/v1/articles' )

diff --git a/src/blocks/homepage-articles/view.js b/src/blocks/homepage-articles/view.js
@@ -51,12 +51,11 @@ function buildLoadMoreHandler( blockWrapperEl ) {
 		blockWrapperEl.classList.remove( 'is-error' );
 		blockWrapperEl.classList.add( 'is-loading' );
 
-		const requestURL = new URL( btnEl.getAttribute( 'data-next' ) );
+		// Set currently rendered posts' IDs as a query param (e.g. exclude_ids=1,2,3)
+		const requestURL =
+			btnEl.getAttribute( 'data-next' ) + '&exclude_ids=' + getRenderedPostsIds().join( ',' );
 
-		// Set currenty rendered posts' IDs as a query param (e.g. exclude_ids=1,2,3)
-		requestURL.searchParams.set( 'exclude_ids', getRenderedPostsIds().join( ',' ) );
-
-		fetchWithRetry( { url: requestURL.toString(), onSuccess, onError }, fetchRetryCount );
+		fetchWithRetry( { url: encodeURI( requestURL ), onSuccess, onError }, fetchRetryCount );
 
 		/**
 		 * @param {Object} data Post data