fix(model): support calling create() with undefined as first argu…

…ment and no callback Fix #9765
Automattic · Jan 6, 2021 · dd132ee · dd132ee
1 parent dec79db
commit dd132ee
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -3000,7 +3000,7 @@ Model.create = function create(doc, options, callback) {
     const last = arguments[arguments.length - 1];
     options = {};
     // Handle falsy callbacks re: #5061
-    if (typeof last === 'function' || !last) {
+    if (typeof last === 'function' || (arguments.length > 1 && !last)) {
       cb = last;
       args = utils.args(arguments, 0, arguments.length - 1);
     } else {

diff --git a/test/model.create.test.js b/test/model.create.test.js
@@ -17,7 +17,7 @@ const DocumentObjectId = mongoose.Types.ObjectId;
  */
 
 const schema = new Schema({
-  title: { type: String, required: true }
+  title: { type: String }
 });
 
 describe('model', function() {
@@ -187,6 +187,14 @@ describe('model', function() {
           }).
           catch(done);
       });
+
+      it('treats undefined first arg as doc rather than callback (gh-9765)', function() {
+        return B.create(void 0).
+          then(function(doc) {
+            assert.ok(doc);
+            assert.ok(doc._id);
+          });
+      });
     });
   });
 });