fix(model): make syncIndexes() report error if it can't create an i…

…ndex Fix #9303
Automattic · Aug 8, 2020 · c90c89e · c90c89e
1 parent d0db150
commit c90c89e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/model.js b/lib/model.js
@@ -1568,7 +1568,7 @@ function _ensureIndexes(model, options, callback) {
       model.emit('error', err);
     }
     model.emit('index', err || indexError);
-    callback && callback(err);
+    callback && callback(err || indexError);
   };
 
   for (const index of indexes) {

diff --git a/test/model.indexes.test.js b/test/model.indexes.test.js
@@ -558,7 +558,7 @@ describe('model', function() {
         assert.deepEqual(indexes[1].key, { username: 1 });
         assert.ok(!indexes[1].collation);
 
-        userSchema = new mongoose.Schema({ username: String });
+        userSchema = new mongoose.Schema({ username: String }, { autoIndex: false });
         userSchema.index({ username: 1 }, {
           unique: true,
           collation: {
@@ -569,7 +569,6 @@ describe('model', function() {
         db.deleteModel('User');
         User = db.model('User', userSchema, 'User');
 
-        yield User.init();
         yield User.syncIndexes();
 
         indexes = yield User.listIndexes();