fix(document): respect child schema minimize if toObject() is cal…

…led without an explicit `minimize` Fix #9405
Automattic · Sep 10, 2020 · b018d2d · b018d2d
1 parent 57a015a
commit b018d2d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/lib/document.js b/lib/document.js
@@ -3078,13 +3078,14 @@ Document.prototype.$toObject = function(options, json) {
 
   // If options do not exist or is not an object, set it to empty object
   options = utils.isPOJO(options) ? clone(options) : {};
+  options._calledWithOptions = options._calledWithOptions || clone(options);
 
   if (!('flattenMaps' in options)) {
     options.flattenMaps = defaultOptions.flattenMaps;
   }
 
   let _minimize;
-  if (options.minimize != null) {
+  if (options._calledWithOptions.minimize != null) {
     _minimize = options.minimize;
   } else if (defaultOptions.minimize != null) {
     _minimize = defaultOptions.minimize;

diff --git a/test/utils.test.js b/test/utils.test.js
@@ -250,8 +250,6 @@ describe('utils', function() {
       assert.deepEqual(out.arr[0], { a: 42 });
       assert.deepEqual(out.arr[1], {});
       assert.deepEqual(out.arr[2], {});
-
-      return Promise.resolve();
     });
   });