fix(cursor): make sure to clear stack every 1000 docs when calling `n…

…ext()` to avoid stack overflow with large batch size Fix #10449
Automattic · Aug 9, 2021 · a0bdcfe · a0bdcfe
1 parent 95685e2
commit a0bdcfe
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/lib/cursor/QueryCursor.js b/lib/cursor/QueryCursor.js
@@ -422,6 +422,11 @@ function _onNext(error, doc) {
   this.ctx._batchDocs.push(doc);
 
   if (this.ctx._batchDocs.length < this.ctx.options._populateBatchSize) {
+    // If both `batchSize` and `_populateBatchSize` are huge, calling `next()` repeatedly may
+    // cause a stack overflow. So make sure we clear the stack regularly.
+    if (this.ctx._batchDocs.length > 0 && this.ctx._batchDocs.length % 1000 === 0) {
+      return immediate(() => this.ctx.cursor.next(_onNext.bind(this)));
+    }
     this.ctx.cursor.next(_onNext.bind(this));
   } else {
     _populateBatch.call(this);