Reinstate PHPCS and update VIP sniffs #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes SNIFF variable (commented out!) from previous PHP versions and adds it to the most recent PHP version.
Includes the new VIP-Coding-Standards repo and ensures we're running phpcs with the newer WordPress-VIP-Go ruleset.
We need to clone the VIP Coding Standards into it's own directory otherwise it conflicts with the WP coding standards
We don't need to check things like the entire vendor folder and compiled assets so let's skip them in PHPCS.
|
The only failures here are because the PHPCS check (now added back) is flagging some issues. We don't need to address those in this PR. They should (hopefully) be addressed in #486 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-instates the PHPCS sniffs via Travis. It also includes the new VIP Coding Standards repo and runs the newer
WordPress-VIP-Gostandard.Fixes #540