Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Add --use-version option to jetpack release #41095

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Jan 15, 2025

Proposed changes:

Many of the various commands run by jetpack release can take an option for a specific version. Allow this to be done.

In particular, this will be useful for doing the 1.0.0 release of a package.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

p1736961528818299/1736959724.475999-slack-C05Q5HSS013

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • Try the various subcommands with the --use-version option to see if they behave appropriately.

Many of the various commands run by `jetpack release` can take an option
for a specific version. Allow this to be done.

In particular, this will be useful for doing the 1.0.0 release of a
package.
@anomiex anomiex added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Jan 15, 2025
@anomiex anomiex requested a review from a team January 15, 2025 17:35
@anomiex anomiex self-assigned this Jan 15, 2025
@github-actions github-actions bot added the [Tools] Development CLI The tools/cli to assist during JP development. label Jan 15, 2025
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me.

I'll note in general it's a bit confusing that there are sometimes positional args for version, and now there's a --use-version flag. And then we have promptForVersion, which sets version, and we have version_type...

@anomiex anomiex merged commit 62e0a5a into trunk Jan 15, 2025
59 checks passed
@anomiex anomiex deleted the add/cli-release-use-version-option branch January 15, 2025 17:57
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Jan 15, 2025
@anomiex
Copy link
Contributor Author

anomiex commented Jan 15, 2025

Yeah, possibly some of that could be cleaned up. Although I don't think jetpack release ever takes the version as a positional arg.

@tbradsha
Copy link
Contributor

Although I don't think jetpack release ever takes the version as a positional arg.

Indeed, I was misreading it. :^)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Tools] Development CLI The tools/cli to assist during JP development. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants