-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Image: Update Ubuntu version to 21.04 #22449
Conversation
While trying to install the Jurassic Tube scripts on an M1 Mac, I was seeing segmentation fault errors from the `curl` commands. After some investigation, it looks to be a problem with `libcrypto` and upgrading the base image to ubuntu:21.04 fixes the issue.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update went just fine for me on an M1. I'll let @anomiex chime in to see how it goes on his system, but I think we should be good to go!
Works as far as it goes, but I note 21.04 is already end-of-life. 21.10 was released in October, so we might want to try that instead. Also a new LTS (22.04) is scheduled for release on April 21, which we'll probably want to look at once it has come out. Too bad Ubuntu doesn't seem inclined to address this in 20.04. |
Might as well try the jump to 21.10. I'm going to bump it to 21.10 and see if it builds for me fine. I'm not on a M1, though, so can't test for the original bug. |
21.10 worked fine for me, so pushing up that for others to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works for me on M1.
Co-authored-by: Brandon Kraft <public@brandonkraft.com>
Changes proposed in this Pull Request:
While trying to install the Jurassic Tube scripts on an M1 Mac, I was
seeing segmentation fault errors from the
curl
commands. After someinvestigation, it looks to be a problem with
libcrypto
and upgradingthe base image to ubuntu:21.04 fixes the issue.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
jetpack docker build-image
jetpack docker exec curl https://jurassic.tube/jtuber-v0.4.sh
and check that the script is returned with this change.