Blocks: introduce new Podcast Episodes block #14928

jeherve · 2020-03-09T17:57:53Z

Changes proposed in this Pull Request:

Adds scaffolding for a Podcast Episodes block. Implementation to follow in separate PRs.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

paYJgx-sH-p2

Testing instructions:

Check out the PR and build extensions.
Make sure there is a Podcast Episodes (beta) block in the block selector.
Insert in to the editor and make sure it doesn't break the editor or the frontend.

Proposed changelog entry for your changes:

Introduces a beta Podcasts Episodes block.

jeherve · 2020-03-09T17:58:15Z

@marekhrabe I'll let you take that one from there!

jetpackbot · 2020-03-09T17:59:52Z

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 1b6ba78

jeherve · 2020-03-09T18:00:29Z

Adding the "Needs Product Review" as a reminder that it'd be great if you could publish about this new block, its target deadline, and its deployment strategy as explained here:
p1HpG7-8wI-p2

Thank you!

obenland · 2020-03-09T23:36:23Z

I've probably done too much here already, but it works on the front-end, building on the RSS block and re-using Core's audio playlist scripts. The editor preview needs attention.

It's very much possible this will not be the route we'll end up taking, so let me know what you think, or rip it out and start over :)

simison · 2020-03-10T10:42:27Z

extensions/blocks/podcast-episodes/attributes.js

@@ -0,0 +1,12 @@
+const urlValidator = url => ! url || url.startsWith( 'http' );


You could look at isUrl() from @wordpress/url: https://github.com/WordPress/gutenberg/blob/03e3c05eca3ee66b99655e79d2939dafe27a46e3/packages/url/src/is-url.js#L16 or using new URL() native JS API.

simison · 2020-03-10T10:45:04Z

extensions/blocks/podcast-episodes/podcast-episodes.php

+	$rss = fetch_feed( $attributes['url'] );
+
+	if ( is_wp_error( $rss ) ) {
+		return '<div class="components-placeholder"><div class="notice notice-error"><strong>' . __( 'RSS Error:', 'jetpack' ) . '</strong> ' . $rss->get_error_message() . '</div></div>';


Remember to HTML escape the error.

WunderBart · 2020-03-10T14:28:48Z

I've rebased this branch and removed extra commits to be picked up in follow-up PRs as described in this comment (see also p1583833360124800-slack-ajax). For the removed stuff, I created two separate branches with it:

Front-end:
https://github.com/Automattic/jetpack/tree/add/podcast-episodes-frontend
This one is literally a copy of this PR with all the extra commits from @obenland as they’re all needed to make the front-end render.
Edit:
https://github.com/Automattic/jetpack/tree/add/podcast-episodes-edit
This one has the front-end commits removed.

I've tested this one locally and it looks good to me, as far as the scaffolding task is concerned:

Picker	Placeholder

jeherve

The tests are currently failing because the scaffolding introduces variables you can use to build your block, but haven't yet. I'd recommend removing them or adding comments so the tests can pass. You can add those back later on as you build your PRs.

  6:23  error  'withNotices' is defined but never used              no-unused-vars
  16:2   error  'attributes' is defined but never used               no-unused-vars
  20:2   error  'setAttributes' is defined but never used            no-unused-vars
  27:10  error  'notice' is assigned a value but never used          no-unused-vars
  27:18  error  'setNotice' is assigned a value but never used       no-unused-vars
  30:8   error  'setErrorNotice' is assigned a value but never used  no-unused-vars

matticbot · 2020-03-10T16:30:27Z

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40115-code before merging this PR. Thank you!

obenland · 2020-03-10T19:00:57Z

@Automattic/jetpack-crew When you get a chance, I'd love to get this in early so we can start to rebase and continue with follow up PRs. Thank you!

jeherve · 2020-03-11T07:34:23Z

When you get a chance, I'd love to get this in early so we can start to rebase and continue with follow up PRs. Thank you!

I'll take a look in a bit. To speed things up, this may help:

Have someone on your team reviewing, testing, and accepting the changes.
Add the "Needs Review" label so the PR gets on our radar.

For more info about this: p1583857050271600-slack-ajax

github-actions · 2020-03-11T07:34:46Z

Howdy! The Jetpack team has disappeared for a few days to a secret island lair to concoct new ways to make Jetpack one hundred billion percent better. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back next week to look at your work! Thank you for your understanding.

jeherve · 2020-03-11T07:35:06Z

No worries about this ^

This is Hack week for us, but I'll take a look at the PR anyway.

getdave

Tested and it worked for me.

Some minor suggestions for wording tweaks but may not be needed. Will defer to Jetpack Crew on this one.

extensions/blocks/podcast-episodes/edit.js

jeherve

This should be good to ship as is, so y'all can start iterating on this.

zinigor

The code looks good, keeping in mind that it's just a scaffold for the real thing. Let's merge!

* Initial changelog entry * Changelog: add #14904 * Changelog: add #14910 * Changelog: add #14913 * Changelog: add #14916 * Changelog: add #14922 * Changelog: add #14924 * Changelog: add #14925 * Changelog: add #14928 * Changelog: add #14840 * Changelog: add #14841 * Changelog: add #14842 * Changelog: add #14826 * Changelog: add #14835 * Changelog: add #14859 * Changelog: add #14884 * Changelog: add #14888 * Changelog: add #14817 * Changelog: add #14814 * Changelog: add #14819 * Changelog;: add #14797 * Changelog: add #14798 * Changelog: add #14802 * Changelog: add #13676 * Changelog: add #13744 * Changelog: add #13777 * Changelog: add #14446 * Changelog: add #14739 * Changelog: add #14770 * Changelog: add #14784 * Changelog: add #14897 * Changelog: add #14898 * Changelog: add #14968 * Changelog: add #14985 * Changelog: add #15044 * Changelog: add #15052 * Update to remove Podcast since it remains in Beta * Changelog: add #14803 * Changelog: add #15028 * Changelog: add #15065 * Changelog:add #14886 * Changelog: add #15118 * Changelog: add #14990 * Changelog: add #14528 * Changelog: add #15120 * Changelog: add #15126 * Changelog: add #15049 * Chanegelog: add #14852 * Changelog: add #15090 * Changelog: add #15138 * Changelog: add #15124 * Changelog:add #15055 * Changelog: add #15017 * Changelog: add #15109 * Changelog: add #15145 * Changelog:add #15096 * Changelog:add #15153 * Changelog: add #15133 * Changelog: add #14960 * Changelog: add #15127 * Changelog: add #15056 * Copy current changelog to changelog archive. * Clarify changelog description

Blocks: introduce new Podcast Episodes block

506900b

jeherve added [Status] In Progress [Type] Feature Request [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Mar 9, 2020

jeherve assigned marekhrabe Mar 9, 2020

matticbot added the Touches WP.com Files label Mar 9, 2020

jeherve added the [Status] Needs Product Review Consider posting about this on an internal P2 for discussion label Mar 9, 2020

Add proper icon

8862522

simison reviewed Mar 10, 2020

View reviewed changes

WunderBart force-pushed the add/podcast-episodes-block branch from 84b296b to 8862522 Compare March 10, 2020 14:21

jeherve commented Mar 10, 2020

View reviewed changes

obenland marked this pull request as ready for review March 10, 2020 16:50

obenland requested a review from a team March 10, 2020 16:50

jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] In Progress labels Mar 10, 2020

WunderBart removed the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Mar 10, 2020

Ignore unused vars (for now) to fix linter errors

1b6ba78

WunderBart force-pushed the add/podcast-episodes-block branch from 9f20ab5 to 1b6ba78 Compare March 10, 2020 17:13

jeherve added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 11, 2020

jeherve added this to the 8.4 milestone Mar 11, 2020

getdave approved these changes Mar 11, 2020

View reviewed changes

extensions/blocks/podcast-episodes/edit.js Show resolved Hide resolved

extensions/blocks/podcast-episodes/edit.js Show resolved Hide resolved

extensions/blocks/podcast-episodes/edit.js Show resolved Hide resolved

jeherve commented Mar 11, 2020

View reviewed changes

jeherve added [Status] Ready to Merge Go ahead, you can push that green button! [Block] Podcast Player and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 11, 2020

zinigor approved these changes Mar 11, 2020

View reviewed changes

zinigor merged commit c274402 into master Mar 11, 2020

zinigor deleted the add/podcast-episodes-block branch March 11, 2020 11:39

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 11, 2020

getdave mentioned this pull request Mar 11, 2020

Podcast Player (previous "Episodes") Block Edit #14948

Merged

9 tasks

jeherve added [Status] Has Changelog and removed [Status] Needs Changelog [Status] Needs Product Review Consider posting about this on an internal P2 for discussion labels Mar 20, 2020

jeherve added a commit that referenced this pull request Mar 20, 2020

Changelog: add #14928

1b31cb0

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Blocks: introduce new Podcast Episodes block #14928

Blocks: introduce new Podcast Episodes block #14928

jeherve commented Mar 9, 2020 •

edited by obenland

Loading

jeherve commented Mar 9, 2020

jetpackbot commented Mar 9, 2020 •

edited

Loading

jeherve commented Mar 9, 2020

obenland commented Mar 9, 2020

simison Mar 10, 2020 •

edited

Loading

simison Mar 10, 2020

WunderBart commented Mar 10, 2020 •

edited

Loading

jeherve left a comment

matticbot commented Mar 10, 2020

obenland commented Mar 10, 2020

jeherve commented Mar 11, 2020 •

edited

Loading

github-actions bot commented Mar 11, 2020

jeherve commented Mar 11, 2020

getdave left a comment

jeherve left a comment

zinigor left a comment

		@@ -0,0 +1,12 @@
		const urlValidator = url => ! url \|\| url.startsWith( 'http' );

Blocks: introduce new Podcast Episodes block #14928

Blocks: introduce new Podcast Episodes block #14928

Conversation

jeherve commented Mar 9, 2020 • edited by obenland Loading

Changes proposed in this Pull Request:

Is this a new feature or does it add/remove features to an existing part of Jetpack?

Testing instructions:

Proposed changelog entry for your changes:

jeherve commented Mar 9, 2020

jetpackbot commented Mar 9, 2020 • edited Loading

jeherve commented Mar 9, 2020

obenland commented Mar 9, 2020

simison Mar 10, 2020 • edited Loading

Choose a reason for hiding this comment

simison Mar 10, 2020

Choose a reason for hiding this comment

WunderBart commented Mar 10, 2020 • edited Loading

jeherve left a comment

Choose a reason for hiding this comment

matticbot commented Mar 10, 2020

obenland commented Mar 10, 2020

jeherve commented Mar 11, 2020 • edited Loading

github-actions bot commented Mar 11, 2020

jeherve commented Mar 11, 2020

getdave left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

zinigor left a comment

Choose a reason for hiding this comment

jeherve commented Mar 9, 2020 •

edited by obenland

Loading

jetpackbot commented Mar 9, 2020 •

edited

Loading

simison Mar 10, 2020 •

edited

Loading

WunderBart commented Mar 10, 2020 •

edited

Loading

jeherve commented Mar 11, 2020 •

edited

Loading