Code

Slideshow Block: AMP Compatibility#13009

Code

Merged

jeffersonrabb merged 25 commits intomasterAutomattic/jetpack:masterfrom add/amp-slideshowAutomattic/jetpack:add/amp-slideshowCopy head branch name to clipboardOct 3, 2019

+205-7

Commits

Commits on Sep 28, 2019

• Slideshow block, AMP compatibility, initial commit.

  jeffersonrabb

  committed
  7798351

  Copy full SHA for 7798351

• Background image data URIs don't seem to work in AMP unless spaces are encoded.

  jeffersonrabb

  committed
  4d36cc0

  Copy full SHA for 4d36cc0

• Aria labels for next and previous buttons.

  jeffersonrabb

  committed
  399667b

  Copy full SHA for 399667b

• Slideshow pagination control in AMP.

  jeffersonrabb

  committed
  e9afb43

  Copy full SHA for e9afb43

• Safer global for Slideshow ID.

  jeffersonrabb

  committed
  a166b78

  Copy full SHA for a166b78

• Attribute and caption escaping.

  jeffersonrabb

  committed
  2fe9c56

  Copy full SHA for 2fe9c56

• Extract Slideshow AMP rendering to a separate function.

  jeffersonrabb

  committed
  3b3eb3c

  Copy full SHA for 3b3eb3c

• Use wp_get_attachment_image() and let image sanitizer manage. Use 'large' size rather than 'full.'

  jeffersonrabb

  committed
  5d52ab4

  Copy full SHA for 5d52ab4

• Additional attribute escaping.

  jeffersonrabb

  committed
  ba5e923

  Copy full SHA for ba5e923

• Bug fix: remove autoplay override used for testing.

  jeffersonrabb

  committed
  9d02095

  Copy full SHA for 9d02095

• Unnecessary style removal.

  jeffersonrabb

  committed
  188f089

  Copy full SHA for 188f089

Commits on Sep 29, 2019

• Autoplay pause/play button implementation for AMP.

  jeffersonrabb

  committed
  cabea0d

  Copy full SHA for cabea0d

• Set AMP Carousel dimensions based on the aspect ratio of the first image.

  jeffersonrabb

  committed
  3cfa901

  Copy full SHA for 3cfa901

• Use static variable instead of Global for Slideshow block unique ID.

  jeffersonrabb

  committed
  6e225a7

  Copy full SHA for 6e225a7

• Some refactoring to reduce size of individual functions.

  jeffersonrabb

  committed
  63815f2

  Copy full SHA for 63815f2

• Further refactoring to reduce function length.

  jeffersonrabb

  committed
  3e8b991

  Copy full SHA for 3e8b991

• Remove negative top margin for next/prev buttons in AMP requests.

  jeffersonrabb

  committed
  c7964a8

  Copy full SHA for c7964a8

Commits on Sep 30, 2019

• Selected state for Slideshow block bullets in AMP requests.

  jeffersonrabb

  committed
  64107c7

  Copy full SHA for 64107c7

• Remove short array syntax.

  jeffersonrabb

  committed
  adeb84e

  Copy full SHA for adeb84e

• Bug fix: incorrect element ID used in autoplay pause/play buttons.

  jeffersonrabb

  committed
  9f5952f

  Copy full SHA for 9f5952f

• Improvements to formatted string statements.

  jeffersonrabb

  committed
  e4c02de

  Copy full SHA for e4c02de

• Escaping improvements for Slideshow block bullets.

  jeffersonrabb

  committed
  80e89e1

  Copy full SHA for 80e89e1

• Check for existence of image dimensions, use 800x600 as fallback.

  jeffersonrabb

  committed
  4cd6190

  Copy full SHA for 4cd6190

• Use Jetpack_Gutenberg's block_classes to generate block class list.

  jeffersonrabb

  committed
  15ab418

  Copy full SHA for 15ab418

Commits on Oct 1, 2019

• Improved approach to translating bullet ARIA labels.

  jeffersonrabb

  committed
  9fcd5eb

  Copy full SHA for 9fcd5eb