Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow Block: Fix Class Typo #12526

Merged
merged 2 commits into from
Jun 3, 2019

Conversation

Aurorum
Copy link
Contributor

@Aurorum Aurorum commented May 31, 2019

Fixes Automattic/wp-calypso#33297

Changes proposed in this Pull Request:

This typo was initially something I noticed in Automattic/wp-calypso#31295 which confused me slightly then, but it doesn't have any impact on the block itself. Since there's an open issue for it and it's a very easy fix, may as well fix the class name.

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • N/a

Testing instructions:

  • Add a Slideshow Block
  • Verify that the styles for wp-block-jetpack-slideshow_swiper-wrapper are still present

Proposed changelog entry for your changes:

Almost certainly not needed but if so:

  • Slideshow block: fix typo in class name.

@Aurorum Aurorum requested a review from a team May 31, 2019 19:14
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ecd2c68

@jeherve jeherve added [Block] Slideshow [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Bug When a feature is broken and / or not performing as intended labels Jun 3, 2019
@jeherve jeherve added this to the 7.5 milestone Jun 3, 2019
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems harmless. Nice catch! Merging now.

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jun 3, 2019
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello torres126! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D29010-code before merging this PR. Thank you!

@jeherve jeherve merged commit 2551a29 into Automattic:master Jun 3, 2019
@jeherve jeherve self-assigned this Jun 3, 2019
@matticbot matticbot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jun 3, 2019
jeherve added a commit that referenced this pull request Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Slideshow [Pri] Low Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gutenberg Slideshow block: minor typo in classname
4 participants