Memberships: Rename to "Recurring Payments" #12488

artpi · 2019-05-29T14:57:44Z

Based on feedback from multiple sources, we've decided to change the name from Memberships to "Recurring Payments".

This PR accomplishes that in regards to the block.

Screenshots

Changes

No functional changes, except naming.

Testing instructions

Same as #9802

jetpackbot · 2019-05-29T15:00:18Z

	Warnings
⚠️	"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against f34bb05

davemart-in

Looks good to me! 👍

jeherve

This seems to work. Is the Calypso page change coming in wp-calypso as well, I suppose?

I'm not super clear on the naming, and what actually sounds better / is correct English:

Recurring Payment plans or Recurring Payments plans
Recurring Payments plan or Recurring Payments plan

Also, should we capitalize everything, only Recurring Plans, or only Recurring?

Could we get Editorial's review on this maybe?

jeherve · 2019-05-29T17:33:08Z

extensions/blocks/recurring-payments/edit.jsx

 						notices={ notices }
 					>
 						<div className="components-placeholder__instructions wp-block-jetpack-membership-button">
-							{ __( "You'll need to upgrade your plan to use the Membership Button.", 'jetpack' ) }
+							{ __(
+								"You'll need to upgrade your plan to use the Recurring Payment Button.",


Should it be payments?

Suggested change

"You'll need to upgrade your plan to use the Recurring Payment Button.",

"You'll need to upgrade your plan to use the Recurring Payments Button.",

Same for the other instances below.

extensions/index.json

kristastevens · 2019-05-29T18:43:36Z

Hi @artpi, thanks for the ping! "Recurring Payments" is clear as is.

This is likely outside the scope of this PR, though in attempting to view this as a user making a decision on which to choose when offered both options side-by-side, "Simple Payments" gives me pause -- it's not immediately clear what "Simple" refers to. (Is it payments processed by Simple? Does Simple mean quick and easy to implement?) Is there any chance we can add micro-copy or an alt-description / tooltip to the block?

If so, we could have:

Recurring Payments Button (Accept recurring payments.)
Simple Payments Button (Accept one-time payments.)

Thanks again for the ping!

artpi · 2019-05-29T18:57:43Z

Chatted with @kristastevens and we are gonna:

treat "Recurring Payments" as a "name", so always capitalize
We are NEVER using "Recurring Payment" since that is not the name. The name has s.
"Recurring Payments plan" is a thing, as is "Recurring Payments plans". THere are no other forms of plans.

I will implement this in a bit

artpi · 2019-05-29T20:29:38Z

I updated the copy according to the above

jeherve

This works for me. Merge when ready. I'll make sure the changes make it into Jetpack 7.4.

All those changes mean that you'll need to push those changes to WordPress.com manually though. Fusion won't pick up on all the file name changes. :(

Noting that I'm still redirected to https://en.support.wordpress.com/memberships/#stripe-account-connected upon connecting a site to Stripe.

artpi · 2019-05-30T08:09:15Z

Thank you so much! 🦄

This renames the membership block to recurring payments button. Associated filename changes go with this. * Change copy of Memberships to Recurring Payments * few fixes * Change block id to recurring-payment-button * Rename dir * Block id change * Reorder * Settle on one capitalization

jeherve · 2019-05-30T09:57:27Z

Cherry-picked to branch-7.4 in fe4fb9a

Following up from #12488

artpi added 2 commits May 29, 2019 16:14

Change copy of Memberships to Recurring Payments

24334c6

few fixes

73d45c8

artpi requested a review from a team May 29, 2019 14:57

artpi self-assigned this May 29, 2019

matticbot added the Touches WP.com Files label May 29, 2019

davemart-in previously approved these changes May 29, 2019

View reviewed changes

jeherve added this to the 7.4 milestone May 29, 2019

artpi added 3 commits May 29, 2019 19:00

Change block id to recurring-payment-button

4fb37c0

Rename dir

517c3a2

Block id change

d4ed377

artpi dismissed davemart-in’s stale review via d4ed377 May 29, 2019 17:14

jeherve requested changes May 29, 2019

View reviewed changes

jeherve removed the [Status] Needs Copy Review Copy has been added. Marketing will be notified for a copy review. label May 29, 2019

artpi added 2 commits May 29, 2019 22:14

Reorder

0fadbfc

Settle on one capitalization

f34bb05

artpi added [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 29, 2019

jeherve approved these changes May 29, 2019

View reviewed changes

jeherve removed the [Status] Needs Review A Jetpack Crew expert's review is needed. Typically for significant changes to core functionality. label May 29, 2019

jeherve added [Status] Needs Cherry-Pick [Status] Ready to Merge Go ahead, you can push that green button! labels May 29, 2019

artpi merged commit 2a1886d into master May 30, 2019

matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 30, 2019

artpi deleted the memberships/rename branch May 30, 2019 08:09

jeherve added a commit that referenced this pull request May 30, 2019

Recurring Payments: update readme to use the new name.

490b044

Following up from #12488

jeherve mentioned this pull request May 30, 2019

Recurring Payments: update readme to use the new name. #12503

Merged

jeherve added a commit that referenced this pull request May 30, 2019

Recurring Payments: update readme to use the new name. (#12503)

bfc71db

Following up from #12488

jeherve added a commit that referenced this pull request May 30, 2019

Recurring Payments: update readme to use the new name. (#12503)

66e8373

Following up from #12488

jeherve removed [Status] Needs Changelog [Status] Needs Cherry-Pick labels Jun 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Memberships: Rename to "Recurring Payments" #12488

Memberships: Rename to "Recurring Payments" #12488

artpi commented May 29, 2019 •

edited by davemart-in

Loading

jetpackbot commented May 29, 2019 •

edited

Loading

davemart-in left a comment

jeherve left a comment

jeherve May 29, 2019

kristastevens commented May 29, 2019

artpi commented May 29, 2019

artpi commented May 29, 2019

jeherve left a comment

artpi commented May 30, 2019

jeherve commented May 30, 2019

	"You'll need to upgrade your plan to use the Recurring Payment Button.",
	"You'll need to upgrade your plan to use the Recurring Payments Button.",

Memberships: Rename to "Recurring Payments" #12488

Memberships: Rename to "Recurring Payments" #12488

Conversation

artpi commented May 29, 2019 • edited by davemart-in Loading

Screenshots

Changes

Testing instructions

jetpackbot commented May 29, 2019 • edited Loading

davemart-in left a comment

Choose a reason for hiding this comment

jeherve left a comment

Choose a reason for hiding this comment

jeherve May 29, 2019

Choose a reason for hiding this comment

kristastevens commented May 29, 2019

artpi commented May 29, 2019

artpi commented May 29, 2019

jeherve left a comment

Choose a reason for hiding this comment

artpi commented May 30, 2019

jeherve commented May 30, 2019

artpi commented May 29, 2019 •

edited by davemart-in

Loading

jetpackbot commented May 29, 2019 •

edited

Loading