-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slideshow: Fix Javascript Error After Adding Block #11703
Conversation
This is an automated check which relies on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue 👍
Need to pull this in to Automattic/wp-calypso#31793 and release a fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't seem to reproduce the issue right now, but it still works with this branch ¯_(ツ)_/¯
merged to Automattic/wp-calypso#31793 in Automattic/wp-calypso@5a438f0 |
Changes proposed in this Pull Request:
Fixes a Javascript error that occurs when Slideshow block is first added.
Testing instructions:
master
, then runyarn && yarn build-extensions
fix/slideshow-realindex-error
and repeat the steps above. This time there should be no error.Fixes #11702