Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slideshow: Fix Javascript Error After Adding Block #11703

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

jeffersonrabb
Copy link
Contributor

Changes proposed in this Pull Request:

Fixes a Javascript error that occurs when Slideshow block is first added.

Testing instructions:

  • On local instance install Gutenberg plugin (v.5.3 or higher). The issue won't occur without the plugin.
  • Check out master, then run yarn && yarn build-extensions
  • Create a new Post, add Slideshow block, choose an image and create a gallery.
  • The block should fail with a JS error, as described in New Slideshow Block Errors Out In Gutenberg 5.3 #11702
  • Check out fix/slideshow-realindex-error and repeat the steps above. This time there should be no error.

Fixes #11702

@jeffersonrabb jeffersonrabb added [Type] Bug When a feature is broken and / or not performing as intended [Block] Slideshow labels Mar 26, 2019
@jeffersonrabb jeffersonrabb added this to the 7.2 milestone Mar 26, 2019
@jeffersonrabb jeffersonrabb self-assigned this Mar 26, 2019
@jeffersonrabb jeffersonrabb requested review from a team March 26, 2019 22:30
@jetpackbot
Copy link
Collaborator

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 643a0dc

@jeffersonrabb jeffersonrabb added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 26, 2019
Copy link
Member

@sirreal sirreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue 👍

@sirreal
Copy link
Member

sirreal commented Mar 27, 2019

Need to pull this in to Automattic/wp-calypso#31793 and release a fixed jetpack-blocks package.

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't seem to reproduce the issue right now, but it still works with this branch ¯_(ツ)_/¯

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Mar 27, 2019
@sirreal sirreal merged commit 21f9072 into master Mar 27, 2019
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 27, 2019
@sirreal sirreal deleted the fix/slideshow-realindex-error branch March 27, 2019 10:12
@lezama
Copy link
Contributor

lezama commented Mar 28, 2019

merged to Automattic/wp-calypso#31793 in Automattic/wp-calypso@5a438f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Slideshow Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Slideshow Block Errors Out In Gutenberg 5.3
8 participants