Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change spaces to tabs in json files #11646

Closed
wants to merge 1 commit into from
Closed

Change spaces to tabs in json files #11646

wants to merge 1 commit into from

Conversation

simison
Copy link
Member

@simison simison commented Mar 21, 2019

Tabs everywhere makes more sense given the rest of the codebase.

Spaces in package.json seem to be there for historic reasons; NPM enforced them until NPM v5 and nowadays NPM doesn't care.

Recently did the same in Calypso: Automattic/wp-calypso#31543

Next up: run json files with Prettier in pre-commit hook:

`./node_modules/.bin/prettier --ignore-path .eslintignore --write ${ toPrettify.join( ' ' ) }`

That Prettier implementation will anyway need some work with #11633

Changes proposed in this Pull Request:

  • :tab: -> :space:

Testing instructions:

Everything should stay as is. 🎉 🌮

@simison simison requested a review from a team March 21, 2019 19:50
@@ -13,7 +13,7 @@ insert_final_newline = true
trim_trailing_whitespace = true
indent_style = tab

[{.jshintrc,*.json,*.yml}]
Copy link
Member Author

@simison simison Mar 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that .jshintrc file was already using tabs...

@simison simison added the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Mar 21, 2019
@simison
Copy link
Member Author

simison commented Mar 21, 2019

Hmm, actually I could close this since #11507 already does the same for these files. @sirreal I was mostly interested to change .editorconfig here — mind bringing that change to your Prettier PR?

@jetpackbot
Copy link
Collaborator

Warnings
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 8ba0941

@simison simison closed this Mar 21, 2019
@simison simison deleted the update/json-tabs branch March 21, 2019 19:58
@sirreal
Copy link
Member

sirreal commented Mar 21, 2019

mind bringing that change to your Prettier PR?

Sounds great to me 👍

@kraftbj kraftbj removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants