Change spaces to tabs in json files #11646
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabs everywhere makes more sense given the rest of the codebase.
Spaces in
package.json
seem to be there for historic reasons; NPM enforced them until NPM v5 and nowadays NPM doesn't care.Recently did the same in Calypso: Automattic/wp-calypso#31543
Next up: run json files with Prettier in pre-commit hook:
jetpack/bin/pre-commit-hook.js
Line 88 in 8ba0941
That Prettier implementation will anyway need some work with #11633
Changes proposed in this Pull Request:
Testing instructions:
Everything should stay as is. 🎉 🌮