Slideshow: do not render markup when user doesn't select any images (#…

…16231)

* Slideshow: do not render markup when images === 0

* Slideshow: do not render markup when images === 0 in AMP mode

* Slideshow: return early when images === 0

* Slideshow: remove empty line

Co-authored-by: cpap <papazoglou.charalampos@gmail.com>

extensions/blocks/slideshow/slideshow.js

@@ -115,6 +115,11 @@ class Slideshow extends Component {
 	};
 
 	render() {
+		// If user has not selected any images, don't print any markup.
+		if ( ! this.props?.images?.length ) {
+			return null;
+		}
+
 		const { autoplay, className, delay, effect, images } = this.props;
 		// Note: React omits the data attribute if the value is null, but NOT if it is false.
 		// This is the reason for the unusual logic related to autoplay below.

extensions/blocks/slideshow/slideshow.php

@@ -52,10 +52,14 @@ function load_assets( $attr, $content ) {
  * @return string
  */
 function render_amp( $attr ) {
+	if ( empty( $attr['ids'] ) ) {
+		return '';
+	}
+
 	static $wp_block_jetpack_slideshow_id = 0;
 	$wp_block_jetpack_slideshow_id++;
 
-	$ids      = empty( $attr['ids'] ) ? array() : $attr['ids'];
+	$ids      = $attr['ids'];
 	$autoplay = empty( $attr['autoplay'] ) ? false : true;
 	$extras   = array(
 		'wp-amp-block',