Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force fetching ep_wpcli_sync_interrupted transient from remote to allow for more reliable remote interruption #108

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

rinatkhaziev
Copy link

Description

During some testing, it was discovered that wp vip-search stop-indexing doesn't reliably terminate the execution of an already-running process.

I think this is due to the cache value being stuck in local memory, this should help to prevent that by always forcing the remote fetch from the object cache backend.

Checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally (or has an appropriate fallback).
  • This change works and has been tested on a Go sandbox.
  • This change has relevant unit tests (if applicable).
  • This change has relevant documentation additions / updates (if applicable).

Steps to Test

  1. Check out PR.
  2. Spin up an indexing process in a memcached-enabled environment
  3. Run wp vip-search stop-indexing from another session
  4. Repeat the process and verify it gets interrupted properly.

Copy link

@rebeccahum rebeccahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested extensively but this change makes sense to me.

@rebeccahum
Copy link

Opened upstream: 10up#2433

@rebeccahum rebeccahum added [Status] Upstream fix If this has been fixed upstream or in progress to be. and removed [Status] Ready to Deploy labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Upstream fix If this has been fixed upstream or in progress to be.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants