Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UV transform value exports #954

Merged
merged 1 commit into from
Dec 4, 2020

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Dec 1, 2020

This commit adds support for UV transform exports.
We have not yet implemented the import functionality.

@kxl-adsk kxl-adsk added the import-export Related to Import and/or Export label Dec 1, 2020
@dgovil
Copy link
Collaborator Author

dgovil commented Dec 2, 2020

Apologies, the test is failing due to default maya plugins again. I'll fix up the Maya file and and try and institute better validation checks on our side to make sure we aren't committing files with other plugins.

# Traceback (most recent call last):
    #   File "<maya console>", line 1, in <module>
    # RuntimeError: Plug-in, "mtoa", was not found on MAYA_PLUG_IN_PATH.

@dgovil dgovil force-pushed the uv_transform_export branch from 0188faf to 379088d Compare December 2, 2020 00:20
@dgovil
Copy link
Collaborator Author

dgovil commented Dec 2, 2020

Okay I've removed mtoa and any .ai_* setattrs. That should satisfy the CI setup I hope.
I'm not sure I can kick off a new CI by myself, but hopefully should work for whenever you do it.

@kxl-adsk
Copy link

kxl-adsk commented Dec 2, 2020

Started one. You will as well notice that we have clang-format check as well.

@dgovil
Copy link
Collaborator Author

dgovil commented Dec 2, 2020

Started one. You will as well notice that we have clang-format check as well.

Thanks! and yes, that format check will be handy (and I'm glad to see this PR passed it)

@dgovil
Copy link
Collaborator Author

dgovil commented Dec 2, 2020

Looks like the CI failed getting results back

fatal: could not read Username for 'https://github.com': No such device or address

@kxl-adsk
Copy link

kxl-adsk commented Dec 2, 2020

That’s new. I will start it again.

@kxl-adsk
Copy link

kxl-adsk commented Dec 2, 2020

@dgovil There was an incident with GitHub yesterday - could be related - https://www.githubstatus.com/incidents/sxthxvdlljk4

New PF passed.

@dgovil
Copy link
Collaborator Author

dgovil commented Dec 2, 2020

Ah makes sense. Thanks for looking into it too!

@kxl-adsk
Copy link

kxl-adsk commented Dec 2, 2020

Credit goes to @smithw-adsk

Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me! Just two small suggestions for the new code.

In the test though, I'm a little unclear about the use of maya.standalone. I would think that we do want to initialize with the fixturesUtils.setUpClass() call, and then uninitialize() in tearDownClass()?

@dgovil dgovil force-pushed the uv_transform_export branch from 379088d to 0e80673 Compare December 4, 2020 01:56
@dgovil
Copy link
Collaborator Author

dgovil commented Dec 4, 2020

@mattyjams Thanks for the suggestions. Addressed that and pushed a new commit with all the changes.

Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now! Thanks @dgovil!

@kxl-adsk
Copy link

kxl-adsk commented Dec 4, 2020

@dgovil You PR is almost ready to go in, just please address the clang-format-lint check error.

@dgovil dgovil force-pushed the uv_transform_export branch from 0e80673 to f21124d Compare December 4, 2020 16:10
@dgovil
Copy link
Collaborator Author

dgovil commented Dec 4, 2020

@kxl-adsk Done.

@kxl-adsk kxl-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Dec 4, 2020
@kxl-adsk kxl-adsk merged commit 345ab28 into Autodesk:dev Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants