-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for UV transform value exports #954
Conversation
805c1ff
to
0188faf
Compare
Apologies, the test is failing due to default maya plugins again. I'll fix up the Maya file and and try and institute better validation checks on our side to make sure we aren't committing files with other plugins.
|
0188faf
to
379088d
Compare
Okay I've removed mtoa and any |
Started one. You will as well notice that we have clang-format check as well. |
Thanks! and yes, that format check will be handy (and I'm glad to see this PR passed it) |
Looks like the CI failed getting results back
|
That’s new. I will start it again. |
@dgovil There was an incident with GitHub yesterday - could be related - https://www.githubstatus.com/incidents/sxthxvdlljk4 New PF passed. |
Ah makes sense. Thanks for looking into it too! |
Credit goes to @smithw-adsk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good to me! Just two small suggestions for the new code.
In the test though, I'm a little unclear about the use of maya.standalone
. I would think that we do want to initialize with the fixturesUtils.setUpClass()
call, and then uninitialize()
in tearDownClass()
?
379088d
to
0e80673
Compare
@mattyjams Thanks for the suggestions. Addressed that and pushed a new commit with all the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great now! Thanks @dgovil!
@dgovil You PR is almost ready to go in, just please address the clang-format-lint check error. |
0e80673
to
f21124d
Compare
@kxl-adsk Done. |
This commit adds support for UV transform exports.
We have not yet implemented the import functionality.