MAYA-105322 - No undo support for viewport selections of USD objects #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use new Ufe::NamedSelection "MayaSelectTool" for viewport selection, rather than modifying UFE global selection directly.
kxl-adsk
approved these changes
Nov 23, 2020
seando-adsk
commented
Nov 23, 2020
Comment on lines
+761
to
+763
| #if UFE_PREVIEW_VERSION_NUM < 2027 // #ifndef UFE_V2_FEATURES_AVAILABLE | ||
| const MGlobal::ListAdjustment& listAdjustment = _globalListAdjustment; | ||
| #endif |
There was a problem hiding this comment.
Don't this need var anymore with the new named selection code.
Comment on lines
+791
to
+794
| #if UFE_PREVIEW_VERSION_NUM >= 2027 // #ifdef UFE_V2_FEATURES_AVAILABLE | ||
| auto ufeSel = Ufe::NamedSelection::get("MayaSelectTool"); | ||
| ufeSel->append(si); | ||
| #else |
There was a problem hiding this comment.
We simply append any items to select to this named selection. Maya takes care of the replace/toggle/add/deselect.
There was a problem hiding this comment.
Same changes in all the plugins.
| @@ -70,7 +70,7 @@ void UsdStageMap::addItem(const Ufe::Path& path, UsdStageWeakPtr stage) | |||
| { | |||
| // We expect a path to the proxy shape node, therefore a single segment. | |||
| auto nbSegments = | |||
| #ifdef UFE_V0_2_6_FEATURES_AVAILABLE | |||
| #if UFE_PREVIEW_VERSION_NUM >= 2006 | |||
There was a problem hiding this comment.
Fixed this ifdef as I noticed it was wrong.
ppt-adsk
approved these changes
Nov 23, 2020
|
I like the notion of named selection. Is it intended to support multiple named selections? |
huidong-chen
approved these changes
Nov 24, 2020
|
@HdC-adsk Yes, UFE supports any number of named selections. The first time you get one with a specific name it will be created. Subsequent calls to get with that name return the same one. |
* Fixing build error (unused function).
ppt-adsk
approved these changes
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-105322 - No undo support for viewport selections of USD objects