Allow recursive compute with proxy accessor #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
commented
Nov 18, 2020
|
|
||
| namespace MAYAUSD_NS_DEF { | ||
|
|
||
| /*! \class Id |
There was a problem hiding this comment.
We have been starting to use "version" numbers in base proxy shape and VP2RenderDelegate. Tracking what different int's and long's mean can be tricky, so we are bringing this little class to solve it.
williamkrick
approved these changes
Nov 18, 2020
| @@ -50,6 +51,94 @@ | |||
|
|
|||
| namespace MAYAUSD_NS_DEF { | |||
|
|
|||
| /*! /brief Scoped object setting up compute context for accessor | |||
|
|
|||
| Proxy accessor supports nested compute that allows injecting DG dependencies to USD. More | |||
There was a problem hiding this comment.
Is there an extra space before "Proxy"?
There was a problem hiding this comment.
Maybe the other lines have only 3 spaces.
lib/mayaUsd/nodes/proxyAccessor.cpp
Outdated
| } | ||
| } | ||
|
|
||
| //! \brief Construct compute context for both inputs |
There was a problem hiding this comment.
This comment cut off?
williamkrick
approved these changes
Nov 19, 2020
…ve_compute_with_proxy_accessor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy accessor is allowing DG dependencies between Maya's data model and USD. This means we can connect input from a DG node to proxy shape to drive USD attributes AND we can connect the proxy shape outputs to make USD attributes drive other DG nodes.
This also allows injecting DG dependencies between two USD attributes, like for example creating parent constraint between two prims. In order to compute such a setup correctly, we need to allow nested / recursive compute with the proxy accessor.
This PR is doing exactly that and an example of such DG setup is provided as a regression test.