Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix call to non-existent function in pxrUsd plugin's usdTranslatorImport #881

Merged

Conversation

mattyjams
Copy link
Contributor

The existing call to usdTranslatorImport_SetOptionMenuByAnnotation() was replaced with a call to usdTranslatorImport_SetShadingOptionMenuByAnnotation() in #865, but the latter does not exist anywhere. This reverts that change.

The existing call to usdTranslatorImport_SetOptionMenuByAnnotation() was
replaced with a call to usdTranslatorImport_SetShadingOptionMenuByAnnotation()
in Autodesk#865, but the latter does not exist anywhere. This reverts that change.
@mattyjams
Copy link
Contributor Author

@JGamache-autodesk: This change got lumped into #865, which was an otherwise non-shading-related PR. Was there some other intention here?:
https://github.com/Autodesk/maya-usd/pull/865/files#diff-dda3f8c38b95d3d9a4339f961596e4f7c3e596ab3c342aa1ae831ff1510e3443R163

@mattyjams mattyjams added pxr Related to Pixar plugin regression Something that used to work is no longer working labels Nov 2, 2020
Copy link
Collaborator

@JGamache-autodesk JGamache-autodesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. It was experimental code that was removed and was not cleaned-up correctly.

@JGamache-autodesk JGamache-autodesk added the ready-for-merge Development process is finished, PR is ready for merge label Nov 2, 2020
@mattyjams
Copy link
Contributor Author

Sorry about that. It was experimental code that was removed and was not cleaned-up correctly.

Ah, cool. No problem. Thanks for confirming!

@kxl-adsk kxl-adsk merged commit b8a93e2 into Autodesk:dev Nov 3, 2020
@mattyjams mattyjams deleted the pr/fix_pxrUsd_shadingModePopup_handling branch November 3, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pxr Related to Pixar plugin ready-for-merge Development process is finished, PR is ready for merge regression Something that used to work is no longer working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants