Enable USD version check for components distributed separately #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still need to add a test, but wanted to open it to collect feedback. |
seando-adsk
reviewed
Oct 19, 2020
seando-adsk
reviewed
Oct 19, 2020
seando-adsk
reviewed
Oct 19, 2020
seando-adsk
approved these changes
Oct 19, 2020
seando-adsk
requested changes
Oct 19, 2020
seando-adsk
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
USD plugins that are distributed in separate packages should perform runtime USD version check to avoid potential crashes caused by version mismatch. This PR adds:
MAYA_USD_VERSIONandMAYAUSD_VERSIONenv variables via MayaUSD mod fileMAYA_PXR_PLUGINPATH_NAMEenv variable and a service that will append<USD_VERSION>to each path and call RegisterPlugins for them. This service runs only once per Maya session and is triggered by either MayaUSD plugin or mtoh (whichever is loaded first). For example, MayaUSD distribution with USD 20.11 will attempt registration of each path in MAYA_PXR_PLUGINPATH_NAME with the2011subdirectory.