MAYA-105389 - Displacement export #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add registry-based exporter for the displacementShader found in Maya displacement workflows. Outputs to the UsdPreviewSurface that got created when the surface shader was exported.
mattyjams
suggested changes
Oct 21, 2020
There was a problem hiding this comment.
This mostly looks good to me, but I think we should drop the requirement that the exported Material have a UsdPreviewSurface shader connected to its surface terminal. I can kind of see the desire to try to collapse the surfaceShader and displacementShader connections in Maya onto a single UsdPreviewSurface Shader in USD, but I don't think that's necessary. I think it'll only make it tougher when we want to support non-UsdPreviewSurface shading networks with displacement.
test/lib/usd/translators/UsdExportDisplacementTest/SimpleDisplacement.ma
Outdated
Show resolved
Hide resolved
mattyjams
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add registry-based exporter for the displacementShader found in Maya displacement workflows. Outputs to the UsdPreviewSurface that got created when the surface shader was exported.