fix import of "useSpecularWorkflow" input on UsdPreviewSurface shaders #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"useSpecularWorkflow" is an int-typed input attribute in USD, but it's a boolean attribute in Maya, so the value needs to be type-converted during import. The conversion was already being done for export. This fixes an issue where the value was not being set on the Maya shading node and an error message that looks like this was being emitted: Runtime Error: in SetMayaAttr at line 719 of lib/mayaUsd/fileio/utils/readUtil.cpp -- Cannot set value of type 'int' on plug '<shaderName>.useSpecularWorkflow'
…nverts and round-trips correctly
JGamache-autodesk
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useSpecularWorkflowis an int-typed input attribute in USD, but it's a boolean attribute in Maya, so the value needs to be type-converted during import. The conversion was already being done for export.