enable exportDisplayColor in testProxyShapeDrawColors test following #822 #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utodesk#822 Internally, we have a post-process to the testProxyShapeDrawColors test that diffs a render generated from the viewport against a baseline. Following the merge of PR Autodesk#822, the test began to fail since displayColor was no longer being exported, so the color represented in the image was different. This change turns on the exportDisplayColor option to cmds.usdExport() so that displayColor is present in the exported USD, and the rendered image matches the baseline again.
kxl-adsk
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, we have a post-process to the
testProxyShapeDrawColorstest that diffs a render generated from the viewport against a baseline. Following the merge of PR #822, the test began to fail sincedisplayColorwas no longer being exported, so the color represented in the image was different. This change turns on theexportDisplayColoroption tocmds.usdExport()so thatdisplayColoris present in the exported USD, and the rendered image matches the baseline again.