Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset version ids and dirty information when the USD stage is cleared. #748

Merged

Conversation

williamkrick
Copy link
Contributor

@williamkrick williamkrick commented Aug 27, 2020

When the USD stage is set on proxyRenderDelegate we clear the change tracker and render index. At the same time we need to reset the dirty information that we use to track the state of the render index. Once the render index is cleared that old dirty information is meaningless, and sometimes causes us to do the wrong thing when the stage is replaced.

Copy link

@kxl-adsk kxl-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kxl-adsk kxl-adsk added the vp2renderdelegate Related to VP2RenderDelegate label Aug 27, 2020
@williamkrick williamkrick added the ready-for-merge Development process is finished, PR is ready for merge label Aug 28, 2020
@kxl-adsk kxl-adsk merged commit 3f77eab into dev Aug 28, 2020
@kxl-adsk kxl-adsk deleted the krickw/MAYA-106571/reset_dirty_information_when_stage_changes branch August 28, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants