MAYA-105604 Handle empty relative path #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boost filesystem will return an empty path when it can not find a relative one. This will happen when the USD file and the textures are not on the same Windows drive, or with UNC paths.
HamedSabri-adsk
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
lgtm! Thank you.
IMO, we should just drop the dependency on boost::filesystem in maya-usd entirely. It is not that much code if you search.
FWIW, looking at USD 20.08 change log, it appears that they have dropped dependency on boost::filesystem (Issue #679).
kxl-adsk
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boost filesystem will return an empty path when it can not find a
relative one. This will happen when the USD file and the textures are
not on the same Windows drive, or with UNC paths.