fixed unused-but-set-variable on compiling with Maya 2018 earlier than 2018.7 #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huidong-chen
suggested changes
Aug 5, 2020
There was a problem hiding this comment.
Please duplicate the line to the other conditional compilation branch after Line 738:
#elif MAYA_API_VERSION >= 20190000
It might look better to change the for expression to:
for (auto rit = mat.nodes.rbegin(), const auto rend = mat.nodes.rend(); rit != rend; rit++) {
huidong-chen
approved these changes
Aug 5, 2020
huidong-chen
approved these changes
Aug 6, 2020
|
@kremersa I can't find signed CLA by you - did you send us one? Please refer to https://github.com/Autodesk/maya-usd/blob/dev/doc/CONTRIBUTING.md in case you have questions. |
|
@kxl-adsk I just signed and emailed it. Thanks for checking |
|
We got it. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed unused-but-set-variable on compiling with Maya 2018 earlier than 2018.7