MAYA-105232 - misc fixes for python3 #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
commented
Jul 3, 2020
| @@ -99,7 +99,7 @@ def GetVisualStudioCompilerAndVersion(): | |||
| # VisualStudioVersion environment variable should be set by the | |||
| # Visual Studio Command Prompt. | |||
| match = re.search( | |||
| "(\d+).(\d+)", | |||
| r"(\d+)\.(\d+)", | |||
There was a problem hiding this comment.
When using python 3 this gives the following warning:
build.py:102: DeprecationWarning: invalid escape sequence \d
"(\d+).(\d+)",
I believe you got this function from the USD build script. I checked and they made this fix a while ago. The env var has something like "15.0" in it. The r tells python this is a raw string which should not be interpreted. And you need . to find the . otherwise that is the regex matching any char.
There was a problem hiding this comment.
Ugh I see. Great find. Didn't realize that.
| @@ -34,7 +34,6 @@ foreach(INPUT_FILE ${PY_INIT_FILES}) | |||
| get_filename_component(OUTPUT_PATH ${OUTPUT_FILE} DIRECTORY) | |||
| install(FILES | |||
| ${INPUT_FILE} # .py files | |||
| ${INPUT_FILE}c # .pyc files | |||
There was a problem hiding this comment.
We should not install .pyc files. They are not needed and they aren't there in python3 anyways.
HamedSabri-adsk
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.