remove hard-coded "pxr" namespace in favor of PXR_NS in baseExportCommand #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fowlertADSK
approved these changes
Jun 1, 2020
Yeah, we got pretty far down the road building stuff on top of USD before we added C++ namespacing to it, so our internal builds still don't use namespaces. I'm not sure how we might be able to catch this. My best guess would be some kind of custom git pre-commit hook that does a simple search for hard-coded namespacing like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small follow-up fix to #398 and accounts for the case when PXR_USE_NAMESPACES is disabled (which is how Pixar currently builds internally) or when USD is built with anything other than "pxr" as the namespace.