remove support for Maya releases older than 2018 #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should only be specifying one variable for use as the package version for when find_package() is used with a version number. Since we were previously specifying two variables with MAYA_APP_VERSION appearing last, that was the one that ended up being used, so this change simply removes the unused declaration of MAYA_API_VERSION.
murphyeoin
approved these changes
May 19, 2020
| @@ -91,7 +91,7 @@ if (BUILD_USDMAYA_SCHEMAS) | |||
| include(cmake/jinja.cmake) | |||
| endif() | |||
|
|
|||
| find_package(Maya REQUIRED) | |||
| find_package(Maya 2018 REQUIRED) | |||
There was a problem hiding this comment.
@mattyjams Great work and thanks for tackling this one. All the changes look good to me. just one minor thing:
You are now explicitly adding version number 2018 after the follow by REQUIRED keyword. What happens then here with 2019 or above?
There was a problem hiding this comment.
The requested version of "2018" will get passed into the FindMaya.cmake module. At the bottom of that module, we specify that MAYA_APP_VERSION is the version variable to use, so find_package_handle_standard_args() will compare the requested version of "2018" to whatever it found ("2019", "2020", etc.). Since we don't specify EXACT to find_package(), the Maya module will deem the found version compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake will enforce that maya-usd be built with at least Maya 2018 (any API version of that release).
@murphyeoin @robthebloke: Just want to make sure this is cool with you, and that you're not still trying to support any Maya releases before 2018, since I included
plugin/alstuff in this.