[al] When updating a transform via a quat, test for equivalence in quat space #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at space rather than euler angles
kxl-adsk
approved these changes
Apr 22, 2020
ppt-adsk
pushed a commit
that referenced
this pull request
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a transform that is a +270 rotation around the x axis, If this gets set as a quat the euler equivalents would be a -90 degree rotation in x. Previously the code would test to see if the rotations had changed by comparing euler values. This was leading to some pointless rotations being written as overs into the usd stage. By comparing the values as quats instead, the equivalence check now works correctly, and the pointless overs no longer get generated.