Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build when project is not created with Qt. #411

Conversation

HamedSabri-adsk
Copy link
Contributor

No description provided.

@HamedSabri-adsk HamedSabri-adsk requested a review from kxl-adsk April 8, 2020 14:14
@HamedSabri-adsk HamedSabri-adsk added the build Related to building maya-usd repository label Apr 8, 2020
if (${Qt5_FOUND})
target_link_libraries(${TARGET_NAME}
PRIVATE
mayaUsdUI
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we rely here on the fact that mayaUsdUI is dependent on MayaUsd?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can do this all on single line with:
$<IF:$<BOOL:${Qt5_FOUND}>,mayaUsdUI,mayaUsd>

@HamedSabri-adsk HamedSabri-adsk requested a review from kxl-adsk April 8, 2020 15:17
@HamedSabri-adsk HamedSabri-adsk merged commit f95c7ee into sabrih/MAYA-104002/clean_up_part_1 Apr 8, 2020
@HamedSabri-adsk HamedSabri-adsk deleted the sabrih/fix_build_qt_not_available branch April 8, 2020 16:11
ppt-adsk added a commit that referenced this pull request May 30, 2023
* Renamed visibility test.

* Create test to validate sweepMesh render item lifescope.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants