Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated workflow for running preflight. #3545

Merged
merged 1 commit into from
Jan 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/maya-usd-preflight-launcher.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ jobs:
clang_format_linter:
timeout-minutes: 30
runs-on: ubuntu-latest
if: ${{ github.event.assignee.login == 'ecp-maya-devops-adsk' }}
# Start clang format by assigning pull-request to yourself.
if: ${{ github.event.assignee.login == github.event.pull_request.user.login }}
steps:
# Aug 2023: Update from v2 to v3 which uses node16 (node12 is out of support).
- uses: actions/checkout@v3
Expand All @@ -26,7 +27,8 @@ jobs:
timeout-minutes: 400
runs-on: ubuntu-latest
needs: clang_format_linter
if: ${{ github.event.assignee.login == 'ecp-maya-devops-adsk' }}
# Start preflight by assigning pull-request to yourself.
if: ${{ github.event.assignee.login == github.event.pull_request.user.login }}
steps:

# Build start info will be committed here when the remote build is launched
Expand Down
10 changes: 7 additions & 3 deletions doc/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,12 @@ The best bug reports include a detailed way to predictably reproduce the issue,

The USD for Maya project accepts and greatly appreciates contributions. The project follows the [fork & pull](https://help.github.com/articles/using-pull-requests/#fork--pull) model for accepting contributions.

When contributing code, please also include appropriate tests as part of the pull request, and follow the same comment and coding style as the rest of the project. Take a look through the existing code for examples of the testing and style practices the project follows.
It is highly recommended that an issue be logged on GitHub before any work is started. This will allow for early feedback from other developers and avoid multiple parallel efforts.

All development should happen against the "develop" branch of the repository. Please make sure the base branch of your pull request is set to the "develop" branch when filing your pull request.
### Pull Requests

It is highly recommended that an issue be logged on GitHub before any work is started. This will allow for early feedback from other developers and avoid multiple parallel efforts.
When contributing code, please also include appropriate tests as part of the pull request, and follow the same comment and coding style as the rest of the project. Take a look through the existing code for examples of the testing and style practices the project follows. Also read and adhere to the the [Coding guidelines](doc/codingGuidelines.md), many of which are enforced by clang-format checks.

All development should happen against the [dev](https://github.com/Autodesk/maya-usd/tree/dev) branch of the repository. Please make sure the base branch of your pull request is set to the dev branch when submitting your pull request.

All pull requests require at least one approving code reviewer and successful preflight run. Running the preflight is a manual process which can be launched by [assigning the pull request to yourself](https://docs.github.com/en/issues/tracking-your-work-with-issues/assigning-issues-and-pull-requests-to-other-github-users#assigning-an-individual-issue-or-pull-request). A preflight consists of two actions: <i>clang_format_linter</i> and <i>build_preflight</i>. If the clang_format_linter steps fails then the build_preflight action is skipped. The build_preflight action will compile your changes and run the test suite on all the various platforms (Windows, Mac, Linux) and current Maya versions supported. To view the results of both clang_format_linter and build_preflight actions, in your pull request select the <i>Checks</i> tab and then select <i>Pre-flight build on pull request</i>. You'll see both jobs on the left and if either failed you can select it for more information about the failure. For a build failure it will list which jobs (if any) that failed. You can access the build logs by selecting <i>Summary</i> in the left pane and then in the right pane scroll down to the bottom to find a link for the <i>build logs</i> which will download a .zip file containing the build log for each of the builds.
Loading