EMSUSD-820 run more of the Pixar plugin tests #3479
Conversation
There were tests in the "pxrUsdMayaGL" folder in the pxr (Pixar) plugin that were not run. As a first step, make these test be run when testing the plugin. - Add a CMakeLists.txt to setup the test to be run when built using cmake. - Make sure the folder paths are correct while running the test. - Make sure the relative USD files used in assembly are found. - Add one missing baseline image file. - Disable the testRefAssemblyDrawRepresentations unit test since it fails in the "Expanded" mode.
|
Is the plan to leave the test disabled until we find the issue on our end? We actually have hacked out the LoadNone change and disabled the testProxyShapeBase test since this issue directly impacts our productions. Thanks. |
|
Yes. It was unclear at this point if you were still investigating the source of the problem and found a solution or not. In your builds, reverting my changes fixes the problem? That is strange since on our side, building with MayaUSD versions older than my changes still fails to have the "Expanded" mode of the assembly be drawn red. |
There were tests in the "pxrUsdMayaGL" folder in the pxr (Pixar) plugin that were not run. Make these tests be run when testing the plugin in the automated builds using Cmake as the build system. - Add a CMakeLists.txt to setup the test to be run when built using cmake. - Make sure the folder paths are correct while running the test so that the images are generated where they are expected to compare them to the baseline images. - Make sure the relative USD files used in assembly are found by temporarily changing the current directory during the test. - Add one missing baseline image file.
66f2462 to
c5c8cf5
Compare
…sk/maya-usd into bailp/EMSUSD-820/more-pixar-tests
Different Maya version have different defaults for lightning. Add different baseline images to compensate the difference when testing in older Maya versions.
One unit test had not been updated.
|
@dj-mcg putting you as reviewer to verify if the changes made to the test and the additional images would be a problem in Pixar's internal build system and testing suite. |
plugin/pxr/maya/lib/pxrUsdMayaGL/testenv/InstancerDrawTest/baseline/InstancerTest_reload.png
Outdated
Show resolved
Hide resolved
plugin/pxr/maya/lib/pxrUsdMayaGL/testenv/InstancerDrawTest/baseline/InstancerTest_cards_v1.png
Outdated
Show resolved
Hide resolved
Remove the now unecessary additional image.
| @@ -70,25 +121,30 @@ def testGenerateImages(self): | |||
| cmds.file(os.path.abspath('InstancerDrawTest.ma'), | |||
| open=True, force=True) | |||
|
|
|||
| # The cards rendering colors in older versions of Maya is lighter, | |||
| suffix = '' | |||
| if mayaUtils.mayaMajorVersion() <= 2024: | |||
There was a problem hiding this comment.
Hi @pierrebai-adsk - I think we actually need to be checking the MayaUsd version here, since this was a change I pushed back in 10/22, and as a result I'm picking up this imaging difference even though I'm still on Maya 2023. What's the best way to do that from test python scripts?
There was a problem hiding this comment.
I'm assuming cmds.pluginInfo('mayaUsdPlugin', q=True, v=True) would be correct approach?
There was a problem hiding this comment.
PS. Here is the change that introduced the behavior:
#2680
If I'm following versioning history correctly, that means we will have the new imaging results in mayaUsd v0.23.0 and beyond, is that correct?
There was a problem hiding this comment.
Well, just change the test in the backported version. The test is within MayaUSD itself, so it would be strange to check the MayaUSD version.
There were tests in the "pxrUsdMayaGL" folder in the pxr (Pixar) plugin that
were not run. Make these tests be run when testing the plugin in the automated
builds using Cmake as the build system.