MAYA-128764 fix AE refresh #3034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the value of a USD property that previously had the default value for that property creates a USD property-spec, which trigger a USD notification about a property being added. In reality, it is not that a new custom property is added, just that an opinion about a proerty that is being set. The attribute editor handled the addition of a property by recreating the Ui entirely. To differentiate between a real property being added and a property gettig a non-default value, we now add a guard in the various places where we are setting a value to allow the notification handler to know the difference.
seando-adsk
previously approved these changes
Apr 24, 2023
- Make sure undo/redo also are flagged as attribute-setting and not adding attributes. - Fix expected count of add/set in the attribute unit test. - Fix the UI node unit test.
samuelliu-adsk
previously approved these changes
Apr 24, 2023
|
The only PF that failed are due to the known problem with artifactory. |
seando-adsk
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the value of a USD property that previously had the default value for that property creates a USD property-spec, which trigger a USD notification about a property being added. In reality, it is not that a new custom property is added, just that an opinion about a property that is being set.
The attribute editor handled the addition of a property by recreating the UI entirely.
To differentiate between a real property being added and a property getting a non-default value, we now add a guard in the various places where we are setting a value to allow the notification handler to know the difference.