Smart signaling must emit MNodeMessages #3015
Conversation
In order for clients to react to changes, the smart signalling should send either NodeDirty or NodeAttributeChanged to signal clients that they need to update.
test/lib/ufe/testContextOps.py
Outdated
|
|
||
| def nodeDirty(self, node, plug, listeners): | ||
| name = plug.partialName(False, False, False, False, False, True) | ||
| self.nodeDirtyReceived.setdefault(name, [0,])[0] += 1 |
There was a problem hiding this comment.
That some bit-obscure Python trick. defaultdict would be clearer and avoid those [0] all over, of good old if/else :)
https://docs.python.org/3/library/collections.html#collections.defaultdict
|
Preflight failure is valid. New code has undesired side-effect with caching. Will have to rework to expose these counters on a separate "listener" node that will connect on the proxy. |
The update counters should not affect the stage, so they need to be on a separate MPxNode.
Also added testing that changing the whole stage triggers a resync.
Anything that creates a MPlug on the proxy shape will end up causing a leak that will help the USD stage survive the File->New/Open cycle. This leak has been there for quite a while, so let's make sure we are not re-using a tainted prim in the second test. No need to even create a stage listener. The action of getting a plug on the stage is sufficient to re-create that leak.
The leak was fixed via PR #3035
| if (cacheIdNum != _lastKnownStageCacheId) { | ||
| const auto cacheId = UsdStageCache::Id::FromLongInt(cacheIdNum); | ||
| const auto stageCached | ||
| = cacheId.IsValid() && UsdUtilsStageCache::Get().Contains(cacheId); |
There was a problem hiding this comment.
Don't we have multiple stage cache in MayaUSD, for shared/unshared stages, and payload? See stageCache.h.
There was a problem hiding this comment.
I am aware of these caches now. But it looks like our clients prefer a cache accessible directly via USD APIs. This is also the cache used by the proxyShape for its outStageCacheId output, so I am not introducing anything new here.
| # Helper to avoid copy-pasting the entire test | ||
| def doPosAndSizeTests(self, hasFunc, setFunc, getFunc, cmdFunc): | ||
| initialUpdateCount = cmds.getAttr('|transform1|proxyShape1.updateId') |
There was a problem hiding this comment.
Note; a fix was already merged in dev. You might want to merge dev in your branch.
There was a problem hiding this comment.
Yes, I have merged with latest dev as I need the recent leak fix.
|
|
||
| #include <mutex> | ||
|
|
||
| using namespace MAYAUSD_NS_DEF; |
There was a problem hiding this comment.
The macro is only for declaring the namespace so that it gets versioned.. When using the namespace, just use the name "MayaUsd" which will never change.
In order for clients to react to changes, the smart signalling should send either NodeDirty or NodeAttributeChanged to signal clients that they need to update.