MAYA-127758 add edit routing for attributes #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Mar 17, 2023
- Add a helper funtion to restore all edit routers to their default.
- Add a getAttrEditRouterLayer helper function to route attribute editions.
- The routing operation for attribute is named... 'attribute'
- It receives the attribute name in the routing context under the 'attribute' key.
- Add the routing operation name in the routing context under the 'operation' key.
- Declare tokens used in edit routing globally.
- This avoid typos and avoid creating them on each call.
- Use attribute routing in UFE Object3d setVisibility implementation.
- Use attribute routing in UFE attribute holder inplementation for setMetadata, set, clearMetadata.
- Use routed layer when checking editability.
- Allow cancelling routed operations by throwing an exception.
- Add unit tests for attribute routing.
- Add a unit test for canceling a command from within an edit router
- Add a helper funtion to restore all edit routers to their default. - Add a getAttrEditRouterLayer helper function to route attribute editions. - The routing operation for attribute is named... 'attribute' - It receives the attribute name in the routing context under the 'attribute' key. - Add the routing operation name in the routing context under the 'operation' key. - Declare tokens used in edit routing globally. - This avoid typos and avoid creating them on each call. - Use attribute routing in UFE Object3d setVisibility implementation. - Use attribute routing in UFE attribute holder inplementation for setMetadata, set, clearMetadata. - Use routed layer when checking editability. - Allow cancelling routed operations by throwing an exception. - Add unit tests for attribute routing. - Add a unit test for canceling a command from within an edit router
pierrebai-adsk
commented
Mar 17, 2023
| // | ||
| // clang-format off | ||
| #define MAYA_USD_EDIT_ROUTING_TOKENS \ | ||
| /* Tokens shared by multiple edit routers */ \ |
There was a problem hiding this comment.
I took the time to declare the edit routing tokens to avoid typos in the future. This means some existing code changed to use these new declaration, related to cache-to-USD for example. That is why there are more file changed then just the new router.
pierrebai-adsk
commented
Mar 17, 2023
| @@ -26,6 +27,22 @@ using namespace boost::python; | |||
|
|
|||
| namespace { | |||
|
|
|||
| std::string handlePythonException() | |||
| { | |||
There was a problem hiding this comment.
This extract the exception text to be able to log it in Maya.
seando-adsk
previously approved these changes
Mar 23, 2023
4e4f086
vlasovi
previously approved these changes
Mar 23, 2023
seando-adsk
reviewed
Mar 24, 2023
vlasovi
approved these changes
Mar 27, 2023
seando-adsk
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.