Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAYA-124702: retrieve ufe runtime id by data source integer reference #2933

Merged
merged 8 commits into from
Mar 14, 2023
Merged

MAYA-124702: retrieve ufe runtime id by data source integer reference #2933

merged 8 commits into from
Mar 14, 2023

Conversation

perrauo-adsk
Copy link
Contributor

Summary:

  • In order to enable UFE support with custom scene indices, the UFE runtime id must be retrieved.
  • This is because Maya is unaware of what runtime a scene index needs.

Changes:

  • In the case of USD, uppon call to _AppendSceneIndex retrieve the USD Ufe runtime, and return using the provide Ufe::Rtid& data source.

seando-adsk
seando-adsk requested changes Mar 13, 2023
View reviewed changes
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all this new Ufe code should be ifdef protected: #if WANT_UFE_BUILD
I think the reason your preflight passed is because this "sceneIndex" folder is only include when PXR_VERSION >= 2211. In this case we are building with Ufe, but we should still support using that Usd version and no Ufe.

@perrauo-adsk
Merge branch 'dev' of https://github.com/Autodesk/maya-usd into perra…
c93bf12 
…uo/MAYA-124702/scene-index-plugin-changes-ufe-selection-of-usd-data
@perrauo-adsk perrauo-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Mar 14, 2023
@seando-adsk seando-adsk added the ufe Related to UFE component in Maya label Mar 14, 2023
@seando-adsk seando-adsk merged commit 90aff3b into dev Mar 14, 2023
@seando-adsk seando-adsk deleted the perrauo/MAYA-124702/scene-index-plugin-changes-ufe-selection-of-usd-data branch March 14, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seando-adsk seando-adsk seando-adsk approved these changes

Assignees

@ecp-maya-devops-adsk ecp-maya-devops-adsk

Labels
ready-for-merge Development process is finished, PR is ready for merge ufe Related to UFE component in Maya
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@perrauo-adsk @seando-adsk @ecp-maya-devops-adsk