Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-125724 - Implement display layer's wireframe mode for instanced geometry #2883

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Feb 16, 2023

No description provided.

@vlasovi
Copy link
Collaborator Author

vlasovi commented Feb 16, 2023

@seando-adsk The only failed unit test is testUsdExportPackage, which is a known random issue. Preflight can be considered passed

constexpr int sDrawModeAllButBBox
= MHWRender::MGeometry::kAll & ~MHWRender::MGeometry::kBoundingBox;
renderItem->setDrawMode((MHWRender::MGeometry::DrawMode)sDrawModeAllButBBox);
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why this must be done, but I trust you do :)

Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vlasovi vlasovi added the ready-for-merge Development process is finished, PR is ready for merge label Feb 21, 2023
@seando-adsk seando-adsk added the vp2renderdelegate Related to VP2RenderDelegate label Feb 21, 2023
@seando-adsk seando-adsk merged commit 7be51e9 into dev Feb 21, 2023
@seando-adsk seando-adsk deleted the vlasovi/MAYA-125724 branch February 21, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants