Add PXR_USD_WINDOWS_DLL_PATH to all of the windows module templates. #2867
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
approved these changes
Feb 7, 2023
seando-adsk
added a commit
that referenced
this pull request
Mar 9, 2023
|
No preflight needed as the .mod files are not used by the tests. See #2931 for corresponding cmake test changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in #2859
Paths added to the dll search list are not necessarily searched in order, so this change makes sure that PXR_USD_WINDOWS_DLL_PATH is defined in any .mod files for Windows so we don't get .dll clashes.
I changed all 3 windows mod files, because (I'm guessing) that Pixar and Animal Logic aren't using Windows, and those are there only for completeness. Plus anybody that looks to those files as an example of an alternative setup should probably have that variable set.