Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-126541 - Create a more extensive unit test for display layer support during USD to USD duplication #2866

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Feb 6, 2023

Additional testing for USD to USD duplication with display layers. This case covers the bug found by QA during the original feature testing

…is case covers the bug found by QA during the original feature testing
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a unit test as requested by PierreB in the PR #2747

@vlasovi
Copy link
Collaborator Author

vlasovi commented Feb 15, 2023

@seando-adsk The test that I added verfies the fix introduced in the PR #2747 , which is "duplicating from USD to USD a node that is not in the stage root", and I think that's what @pierrebai-adsk wanted me to verify. I'm not sure what else I need to do here.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry about that. I missed that from the new test. Maybe add a comment stating that. If you do, don't worry about re-running the preflight.

@vlasovi vlasovi requested a review from seando-adsk February 16, 2023 16:14
@seando-adsk seando-adsk added unit test Related to unit tests (both python or c++) ready-for-merge Development process is finished, PR is ready for merge labels Feb 16, 2023
@seando-adsk seando-adsk merged commit 3b3f6d7 into dev Feb 16, 2023
@seando-adsk seando-adsk deleted the vlasovi/MAYA-126541 branch February 16, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants