Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-127459 - Create an autotest for USD root layer having a relative path #2861

Merged
merged 6 commits into from
Feb 16, 2023

Conversation

vlasovi
Copy link
Collaborator

@vlasovi vlasovi commented Feb 2, 2023

No description provided.

@vlasovi
Copy link
Collaborator Author

vlasovi commented Feb 2, 2023

@seando-adsk the preflight failed on autotest testUsdExportPackage, which is a known random failure. We can consider the preflight passed.

Comment on lines +89 to +90
# Restore mayaUsd_MakePathRelativeToSceneFile
cmds.optionVar(iv=('mayaUsd_MakePathRelativeToSceneFile', 0))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, you shouldn't have to do this because every test will run with its own set of newly created prefs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple times in the past I stumbled upon problems with prefs that I thought would be reset to default but they werent't. Things like default background color and display layer color. Prefs set during one run of the test would persist at the next run. So now I prefer to be sure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right that is true if you are running the tests locally over and over again. Each test gets its own set of prefs, but they aren't cleared from one run to the next.
Note: this is only a problem locally since the test runs on the build machines run only once.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test.

@seando-adsk seando-adsk added the unit test Related to unit tests (both python or c++) label Feb 3, 2023
@vlasovi vlasovi added the ready-for-merge Development process is finished, PR is ready for merge label Feb 3, 2023
@seando-adsk seando-adsk merged commit e248e90 into dev Feb 16, 2023
@seando-adsk seando-adsk deleted the vlasovi/MAYA-127459 branch February 16, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants