Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import meshes with single samples as static geometry #2860

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

dgovil
Copy link
Collaborator

@dgovil dgovil commented Feb 2, 2023

MayaUSD defaults to importing any animated mesh as blendshape data. Unfortunately, without staticSingleSimples enabled on export, meshes may end up with single time samples on their primvars. This leads to exported files not being able to be roundtripped, and will break skinning as a result

This PR changes the logic so that a single time sample is treated as static instead.

Addresses #2756

MayaUSD defaults to importing any animated mesh as blendshape data. Unfortunately, without staticSingleSimples enabled on export, meshes may end up with single time samples on their primvars. This leads to exported files not being able to be roundtripped, and will break skinning as a result

This PR changes the logic so that a single time sample is treated as static instead.

Addresses Autodesk#2756
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seando-adsk seando-adsk added the import-export Related to Import and/or Export label Feb 22, 2023
@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Feb 23, 2023
@seando-adsk seando-adsk merged commit baca521 into Autodesk:dev Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants