Fixes an issue on layer editor save dialog, where an invalid extension could cause a crash. The fallback is .usd. #2845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n could cause a crash. The fallback is .usd.
|
Given your description of the problem, the fact that it caused crashes, while the code you fixed did not use the invalid null pointer, makes me think that it initially crashed in the caller? I see that it was called in layerManager.cpp, which passed the returned layer pointer to SetEditTarget(), which is where I assume it eventually crashed. So I'd also add a check for null in layerManager.cpp (possibly with an error log). While you fixed one cause why the returned layer can be null, there might be others we don't know about. I think it would be nice to make the caller handle the null case. PS: after trying it, it seems the crash was in updateAllCachedStageWithLayer, which uses the new layer pointer without checking if it is null. |
pierrebai-adsk
requested changes
Jan 26, 2023
…where the file cannot be opened after it was exported. The user is then displayed a message dialog indicating the layer saving was not successful.
pierrebai-adsk
approved these changes
Jan 26, 2023
seando-adsk
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an invalid extension string is provided, USD fails to relocate the file when trying update the cached stage layers and will return a TfNullPtr which results in crash. The fix is to check and update the file path prior to passing to layer export and load operations.