MAYA-127045 Add reparenting rules for Shaders, NodeGraphs and Materials. #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ph and UsdShadeMaterial. Users are able to reparent USD items in the Outliner. However, in some cases, reparenting does not make sense and can lead to problematic situations in LookdevX. The following rules are established, when a user tries to reparent items in the Outliner: - UsdShadeShader can only have UsdShadeNodeGraph/UsdShadeMaterial as parent. - UsdShadeNodeGraph can only have a UsdShadeNodeGraph/UsdShadeMaterial as parent. - UsdShadeMaterial can not have UsdShadeShader/UsdShadeNodeGraph/UsdShadeMaterial as parent. If one of the rules is broken, reparenting is prevented.
JGamache-autodesk
previously approved these changes
Jan 10, 2023
seando-adsk
requested changes
Jan 10, 2023
There was a problem hiding this comment.
This requires a unit test, similar to this one that tests the existing gprim restriction:
https://github.com/Autodesk/maya-usd/blob/dev/test/lib/ufe/testParentCmd.py#L1045
…rials. - Add tests for the new reparenting rules of UsdShadeShader, UsdShadeNodeGraph and UsdShadeMaterial. - Adjust the `testUnparentMultiStage` test to not break the new reparenting rules.
…erials for Maya2023 and later. In Maya 2022, reparenting something to a Material results in: ``` RuntimeError: Object [path/to/material] does not support parenting and therefore cannot be a parent. ```
JGamache-autodesk
approved these changes
Jan 12, 2023
|
@seando-adsk I changed one of the existing tests that was unparenting a Shader, which is no longer allowed. I also added tests for the new reparenting rules. I made the new tests only run for Maya2023 and later, because reparenting something to a Material in Maya2022 results in a runtime error for some reason: If you approve of my changes, the PR is ready for merge. |
seando-adsk
reviewed
Jan 13, 2023
seando-adsk
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-127045 Add reparenting rules for UsdShadeShader, UsdShadeNodeGraph and UsdShadeMaterial.
Users are able to reparent USD items in the Outliner. However, in some cases, reparenting does not make sense and can lead to problematic situations in LookdevX. The following rules are established, when a user tries to reparent items in the Outliner:
If one of the rules is broken, reparenting is prevented.