Maya-126871 Delete compound attributes does not remove their connections. #2800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JGamache-autodesk
previously approved these changes
Jan 5, 2023
…s-remove-connections
I re-run the clang-format but it seems correct to the clang-format. |
seando-adsk
requested changes
Jan 9, 2023
lib/mayaUsd/ufe/UsdAttributes.cpp
Outdated
| @@ -455,6 +455,24 @@ bool UsdAttributes::canRemoveAttribute(const UsdSceneItem::Ptr& item, const std: | |||
| } | |||
| return false; | |||
| } | |||
| static void removeConnections(const PXR_NS::UsdPrim& prim, const SdfPath& srcPropertyPath) | |||
test/lib/ufe/testAttributes.py
Outdated
| @@ -183,6 +183,64 @@ def testAddRemoveAttribute(self): | |||
| with self.assertRaisesRegex(KeyError, "Attribute 'MyAttribute' does not exist") as cm: | |||
| attr = ball35Attrs.attribute("MyAttribute") | |||
|
|
|||
| @unittest.skipIf(os.getenv('UFE_PREVIEW_VERSION_NUM', '0000') < '4024', 'Test for UFE preview version 0.4.24 and later') | |||
There was a problem hiding this comment.
Should really say something about why the test needs 0.4.24. Such as "Test requires xxx feature only available on Ufe 0.4.24 and later"
There was a problem hiding this comment.
I update it.
JGamache-autodesk
approved these changes
Jan 10, 2023
seando-adsk
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR, when deleting a compound attribute, the associated connections are also deleted.
Fixes issue 126871.
How Has This Been Tested?
I updated the existing
testAttributes.pyadding the testtestRemoveCompoundAttribute.