Allow connecting filename attributes. #2733
Merged
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The connection API requires being able to cast to UfeAttribute, the UsdAttributeFilename class was the only one not allowing that. This makes the code uniform.
| @@ -188,7 +188,11 @@ class UsdAttributeGeneric | |||
| //! \brief Interface for USD token attributes. | |||
| class UsdAttributeFilename | |||
| : public Ufe::AttributeFilename | |||
| #ifdef UFE_V4_FEATURES_AVAILABLE | |||
There was a problem hiding this comment.
Copied verbatim from UsdAttributeGeneric at line 165.
There was a problem hiding this comment.
Right that was the only one not transitioned!!!
hodoulp
approved these changes
Nov 24, 2022
| @@ -188,7 +188,11 @@ class UsdAttributeGeneric | |||
| //! \brief Interface for USD token attributes. | |||
| class UsdAttributeFilename | |||
| : public Ufe::AttributeFilename | |||
| #ifdef UFE_V4_FEATURES_AVAILABLE | |||
There was a problem hiding this comment.
Right that was the only one not transitioned!!!
neilh-adsk
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The connection API requires being able to cast to UfeAttribute, the UsdAttributeFilename class was the only one not allowing that. This makes the code uniform.