Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to vaccine python code #2715

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Remove reference to vaccine python code #2715

merged 1 commit into from
Nov 29, 2022

Conversation

tanant
Copy link
Contributor

@tanant tanant commented Nov 10, 2022

Originally introduced in 9ee7aef with the modification of a test file - resolves #2711

 - originally introduced in 9ee7aef
 - resolves #2711
@tanant
Copy link
Contributor Author

tanant commented Nov 10, 2022

@dj-mcg - looks like it was a PR from a bit back, just adding a ping here incase you hadn't localised the issue on your machine

@tanant
Copy link
Contributor Author

tanant commented Nov 10, 2022

@seando-adsk / @neilh-adsk / @santosg87 I believe this is a correct fix for this, but I've done it as an eyeball-only fix for speed so you know, with speed comes risk and so would appreciate sanity check here.

@seando-adsk seando-adsk added the unit test Related to unit tests (both python or c++) label Nov 15, 2022
@dj-mcg
Copy link
Collaborator

dj-mcg commented Nov 16, 2022

Ugh thanks - this has been blowing up at the studio. Any suggestions on how to combat it would be great! Sorry that it slipped into the open source code

@tanant
Copy link
Contributor Author

tanant commented Nov 25, 2022

@dj-mcg all good, stuff happens - we do have the security tools - https://apps.autodesk.com/MAYA/en/Detail/Index?id=8637238041954239715 which has a cleanup inside it (but you probably already have a good idea how you'd do it with custom script).

If you can track it back to a point in time, then files post that date could be converted/checked (e.g. you could set a job to open scripts + patch/clean on one machine maybe?)

Other more global solutions could be to set (I believe it's a userpref) your to execute script nodes on file open - but you may actually want that behaviour - or just installing a callback to pick it up on script open time.

Sorry, I don't really have much of a better set of thoughts than that :(

@neilh-adsk neilh-adsk merged commit c825225 into dev Nov 29, 2022
@neilh-adsk neilh-adsk deleted the vaccine_file_fix branch November 29, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Related to unit tests (both python or c++)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test File Vaccine
5 participants