MAYA-115170 fix export when exportRoots and stripNamespaces are combined #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Sep 9, 2022
- Move the dictionary-value extractor functions from jobArgs.cpp to a utility namespace.
- Fix the problem of export roots and strip namespace by using the list of roots to limit whih objects are processed.
- This is done by using the roots as the list of objects to export.
- Add unit test based on problem report.
- Move the dictionary-value extractor functions from jobArgs.cpp to a utility namespace. - Fix the problem of export roots and strip namespace by using the list of roots to limit whih objects are processed. - This is done by using the roots as the list of objects to export. - Add unit test based on problem report.
pierrebai-adsk
commented
Sep 9, 2022
| using namespace PXR_NS; | ||
|
|
||
| /// Extracts a bool at \p key from \p userArgs, or false if it can't extract. | ||
| bool extractBoolean(const VtDictionary& userArgs, const TfToken& key) |
There was a problem hiding this comment.
All this code was moved as-is from jobArgs.cpp, except from renaming them with a extract prefix instead of an underscore and putting them in a namespace.
pierrebai-adsk
commented
Sep 9, 2022
|
|
||
| filePath = os.path.join(inputPath, "UsdExportRootsTest", "UsdExportRootsTest.ma") | ||
| cmds.file(filePath, force=True, open=True) | ||
| cls.filePath = os.path.join(inputPath, "UsdExportRootsTest", "UsdExportRootsTest.ma") | ||
|
|
There was a problem hiding this comment.
Now that there is a test not using this file, the scene needs to be open by each test. Probably makes the tests more independent and avoid accidental interactions.
pierrebai-adsk
commented
Sep 9, 2022
| @@ -75,159 +76,8 @@ TF_DEFINE_PRIVATE_TOKENS( | |||
| // clang-format on | |||
|
|
|||
| namespace { | |||
| /// Extracts a bool at \p key from \p userArgs, or false if it can't extract. | |||
There was a problem hiding this comment.
All changes are merely moving all these function n a public namespace for reuse and chaning the call sites to use the new names.
JGamache-autodesk
previously approved these changes
Sep 9, 2022
|
Had a successful PF and review, merely added a letter in a comment in the test... |
JGamache-autodesk
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.